fix(sparql-anything): accept an empty output from a readable, non-empty chunk - #836
Open
ddeboer wants to merge 1 commit into
Open
fix(sparql-anything): accept an empty output from a readable, non-empty chunk#836ddeboer wants to merge 1 commit into
ddeboer wants to merge 1 commit into
Conversation
…ty chunk - Check a process’s chunk and `load` before starting it, when a path can be seen from this process – a relative one is relative to `workDir` on both sides, an absolute one is the runner’s and may not exist here at all - Fail a missing or empty input then, naming the file, before a JVM runs - Accept a 0-byte output as “no triples” once every input was seen to be non-empty; keep failing an empty output otherwise, and a missing output always, since the converter cannot tell it from an unreadable input - Keep a chunkless job strict: its input is named in the query, which the converter cannot see
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert()rejected any process whose--outputwas empty, because SPARQL Anything exits 0 when it cannot read or parse an input. A chunk whose rows the query filters out entirely writes a 0-byte output too, and was then reported as an unreadable input, aborting the run.The converter now tells the two apart by what it can see before starting a process:
loadpath is relative toworkDirfor the task runner and for the converter alike, so it is checked first: a missing or empty one fails before any JVM runs, naming the file.Docs updated under “Where files are written” and “How a conversion runs”.
Fix #820